From: Richard Levitte - VMS Whacker (richard@levitte.org)
Date: Wed May 04 2005 - 15:16:07 CEST
In message <20050504.094357.15602793.richard@levitte.org> on Wed, 04 May 2005 09:43:57 +0200 (CEST), Richard Levitte - VMS Whacker <richard@levitte.org> said:
richard> In message <200505040656.j446uM4p009631@wumpus.itc.gu.edu.au> on Wed, 04 May 2005 16:56:22 +1000, Anthony Thyssen <anthony@griffith.edu.au> said:
richard>
richard> anthony> Checked the beta2, the resize and is still acting weird.
richard> anthony>
richard> anthony> I select resize from a menu attached to the title bar. My
richard> anthony> cursur jumps to the middle of the window and the resizing
richard> anthony> lines appear.
richard> anthony>
richard> anthony> If I then just click to finish, without touching any window
richard> anthony> edge the window width increases by one charcacter (an xterm)
richard>
richard> *blink*
richard>
richard> I assume you mean one character size. Is that to the right,
richard> down, or both?
Actually, those weren't really about character size, although the
normal font used by xterm just happens to be 6 pixels wide :-)
The following patch seems to fix the problem. The removed additions
were there because I had misunderstood what SetupWindow() wanted (it
wants the x and y coordinate of the outer frame, but the size of the
inner window, which feels quite a bit inconsistent).
--- resize.c 4 May 2005 10:48:19 -0000 1.5.2.2
+++ resize.c 4 May 2005 13:12:13 -0000
@@ -666,8 +666,8 @@
ConstrainSize (tmp_win, &dragWidth, &dragHeight);
AddingX = dragx - tmp_win->frame_bw;
AddingY = dragy - tmp_win->frame_bw;
- AddingW = dragWidth + (2 * tmp_win->frame_bw);
- AddingH = dragHeight + (2 * tmp_win->frame_bw);
+ AddingW = dragWidth;
+ AddingH = dragHeight;
SetupWindow (tmp_win, AddingX, AddingY, AddingW, AddingH, -1);
}
Cheers,
Richard
P.S. Anthony, you're quite an asset! You've been triggering quite a
bunch of obscure bugs, please keep it up! :-)
-----
Please consider sponsoring my work on free software.
See http://www.free.lp.se/sponsoring.html for details.
--
Richard Levitte richard@levitte.org
http://richard.levitte.org/
"When I became a man I put away childish things, including
the fear of childishness and the desire to be very grown up."
-- C.S. Lewis
This archive was generated by hypermail 2.1.4 : Thu May 05 2005 - 06:45:03 CEST